Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932393Ab0AFRG4 (ORCPT ); Wed, 6 Jan 2010 12:06:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932373Ab0AFRGy (ORCPT ); Wed, 6 Jan 2010 12:06:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27953 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932365Ab0AFRGy (ORCPT ); Wed, 6 Jan 2010 12:06:54 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1262797265-26557-1-git-send-email-jslaby@suse.cz> References: <1262797265-26557-1-git-send-email-jslaby@suse.cz> To: Jiri Slaby Cc: dhowells@redhat.com, jmorris@namei.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com, Serge Hallyn Subject: Re: [PATCH 1/1] cred: fix memory leak Date: Wed, 06 Jan 2010 17:06:43 +0000 Message-ID: <20320.1262797603@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 19 Jiri Slaby wrote: > Stanse found a memory leak in prepare_exec_creds. tgcred is not > freed/assigned on all paths. Fix that. > > I.e. unifdef tgcred and add kfree(tgcred); as it is initialized to > NULL already. > > Signed-off-by: Jiri Slaby > Cc: David Howells > Cc: James Morris > Cc: Serge Hallyn Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/