Date: Wed, 6 Jan 2010 20:18:31 +0100
From: Pavel Machek <pavel@ucw.cz>
To: mark gross <mgross@linux.intel.com>
Cc: 640E9920 <640e9920@gmail.com>, linux-pm@lists.linux-foundation.org,
       linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] [RFC] PM_QOS api update to use handles 1/5
Message-ID: <20100106191831.GA3045@elf.ucw.cz>
References: <20091130010953.GA4732@mgross-laptop>
 <20100104083127.GA1450@ucw.cz>
 <20100106191132.GD21316@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100106191132.GD21316@linux.intel.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 25

Hi!

> > Umm.. passing binary numbers like that... is not exactly good
> > interface. Think endianness issues  when writing to it from high-level
> > language.
> 
> yeah.  At the moment I can't recall why I went binary for the ABI, 
> we can revisit this, but its been in the wild for a few years now :(
> 
> I guess I can do some tricks to see if its a hex string representation
> of a number and parse that as well as supporting the s32.  i.e. accept
> strings "0x0000000" ... "0xFFFFFFFF" and return -EINVAL for anything
> else.

Maybe you could use length for detection? If they are writing 4 bytes,
it is s32, 10 bytes means ascii?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/