Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20100106172152.GC17163@lst.de>
References: <20100106172152.GC17163@lst.de>
To: Christoph Hellwig <hch@lst.de>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
       linux@arm.linux.org.uk, starvik@axis.com, jesper.nilsson@axis.com,
       ysato@users.sourceforge.jp, takata@linux-m32r.org, geert@linux-m68k.org,
       zippel@linux-m68k.org, gerg@uclinux.org, ralf@linux-mips.org,
       benh@kernel.crashing.org, schwidefsky@de.ibm.com,
       heiko.carstens@de.ibm.com, lethal@linux-sh.org, davem@davemloft.net,
       jdike@addtoit.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
       viro@zeniv.linux.org.uk
Subject: Re: [PATCH 3/3] generic sys_ipc wrapper
Date: Wed, 06 Jan 2010 19:16:12 +0000
Message-ID: <7501.1262805372@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1143
Lines: 25

Christoph Hellwig <hch@lst.de> wrote:

> various architectures have different strategies for the SHMAT version 1 case
> which apparently never gets used - at least on i386 it seems superflous as
> the compat code on x86-64 and ia64 doesn't even bother to implement it.

The SHMAT version 1 case can be dropped for FRV and MN10300 - neither of them
support iBCS.

> frv goes even further and uses unsigned long for all parameters execept for
> "ptr" which is a pointer type everywhere.  The change from int to unsigned
> long for "third" and back to "int" for the others on frv should be fine due
> to the in-register calling conventions for syscalls (we already had a
> similar issue with the generic sys_ptrace), but I'd prefer to have the arch
> maintainers looks over this in details.

That should be okay - the registers are all 32-bits, so int, long and pointers
are all the same size.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/