DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=PLbUblstUBR/8Fx6yAG1ALnMO37MdaavzZmIt/0GcoTd0gZ7/bSBz7wmIzsudFVQni
         QZDpk7oyQ5/a52bebuDmTM4f41dBdsn0REXHhKt9JL7LBOs89AWRSapsUOxXyHkamw/0
         ajwjby8PLHtKr/0Ph2dq87Xw0Yw4Qf6MrZfMQ=
MIME-Version: 1.0
In-Reply-To: <4B44F3EA.7090002@windriver.com>
References: <1261603190-5036-1-git-send-email-jason.wessel@windriver.com> 
	<1261603190-5036-8-git-send-email-jason.wessel@windriver.com> 
	<1261603190-5036-9-git-send-email-jason.wessel@windriver.com> 
	<1261603190-5036-10-git-send-email-jason.wessel@windriver.com> 
	<8bd0f97a0912261312x4b7c7df6s14ac0137b702044e@mail.gmail.com> 
	<0F1B54C89D5F954D8535DB252AF412FA0553E3A0@chinexm1.ad.analog.com> 
	<4e5ebad50912301845p35b1ea98l2f91c2a209ee863a@mail.gmail.com> 
	<4B44E7E3.10305@windriver.com> <8bd0f97a1001061208x8876e79y507d98e505071067@mail.gmail.com> 
	<4B44F3EA.7090002@windriver.com>
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Wed, 6 Jan 2010 15:39:03 -0500
Message-ID: <8bd0f97a1001061239x5e815590ue7044a4df00df13a@mail.gmail.com>
Subject: Re: [Kgdb-bugreport] [PATCH 09/37] kgdb,blackfin: Add in 
	kgdb_arch_set_pc for blackfin
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Sonic Zhang <sonic.adi@gmail.com>, "Zhang, Sonic" <Sonic.Zhang@analog.com>,
       kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       mingo@elte.hu
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 841
Lines: 18

On Wed, Jan 6, 2010 at 15:34, Jason Wessel wrote:
> Mike Frysinger wrote:
>> also, i see you added "notrace" to the Blackfin probe_kernel_write ...
>> was that intentional ?  if so, this should probably go into
>> include/linux/uaccess.h instead
>
> The notrace was just a cut and paste of the original in mm/maccess.c

ah, i thought i checked mm/maccess.c, but i guess i looked at just
probe_kernel_read().  the fact that this was missed under the Blackfin
code is a good example for why notrace should be on prototypes, not
function definitions :).  i'll send a sep patch for just this.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/