DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=h02zlPkoU6L72INkqoL4RrpLZoDidKWEOJaRcR4D/F+C7ULnIcRM2ayuSqF/5l8btn
         BQF7ejZt7SWNh6Auw/nMOxHEqVgB6agI0MxbHND3jgu5UVK624ibvDAEDvE51i6sndlb
         CXxtmjCTaxXG/JCDj7YmTMad2nMqPCEad30hY=
MIME-Version: 1.0
In-Reply-To: <4B445B0E.50208@redhat.com>
References: <6041d2001001011627o5c494df4v37c0c466df3d444c@mail.gmail.com>
	 <1262392920.32223.10.camel@laptop>
	 <6041d2001001041043ka810288l64ae9d6d8105b284@mail.gmail.com>
	 <4B42AA40.3060406@redhat.com>
	 <6041d2001001041923u7bd512a6w4b5399af17424422@mail.gmail.com>
	 <4B4311E8.1000001@redhat.com>
	 <6041d2001001051458j46cdf7abqc4a0a249445ec348@mail.gmail.com>
	 <4B445B0E.50208@redhat.com>
Date: Wed, 6 Jan 2010 19:44:29 -0500
Message-ID: <6041d2001001061644i59d9cbb6pfcd85177d8391419@mail.gmail.com>
Subject: Re: BUG during shutdown - bisected to commit e2912009
From: Marc Dionne <marc.c.dionne@gmail.com>
To: Xiaotian Feng <dfeng@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
       Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2343
Lines: 52

On Wed, Jan 6, 2010 at 4:42 AM, Xiaotian Feng <dfeng@redhat.com> wrote:
> On 01/06/2010 06:58 AM, Marc Dionne wrote:
>>
>> On Tue, Jan 5, 2010 at 5:18 AM, Xiaotian Feng<dfeng@redhat.com> ?wrote:
>>>
>>> This is outputed by sound module, but it will not affect clockevents,
>>> could
>>> you please try following patch and let me know the output before BUG_ON
>>> happens? We can gather more information on the BUG_ON. Thank you.
>>>
>>> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
>>> index 6f740d9..7c945e8 100644
>>> --- a/kernel/time/clockevents.c
>>> +++ b/kernel/time/clockevents.c
>>> @@ -260,6 +260,9 @@ void clockevents_notify(unsigned long reason, void
>>> *arg)
>>> ? ? ? ? ? ? ? ?list_for_each_entry_safe(dev, tmp,&clockevent_devices,
>>> list)
>>> {
>>> ? ? ? ? ? ? ? ? ? ? ? ?if (cpumask_test_cpu(cpu, dev->cpumask)&&
>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ?cpumask_weight(dev->cpumask) == 1) {
>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (dev->mode != CLOCK_EVT_MODE_UNUSED)
>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? printk("invalid dev %s mode %d on
>>> cpu %d\n", dev->name,
>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? dev->mode, cpu);
>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?BUG_ON(dev->mode !=
>>> CLOCK_EVT_MODE_UNUSED);
>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?list_del(&dev->list);
>>
>> I don't get anything on screen from the printk - is there a trick
>> needed to getting printk output at that stage of shutting down? ?I
>> tried inserting an mdelay() before the BUG, which delayed the bug
>> output but still didn't print the invalid dev message.
>
> Did you notice this BUG when you're doing suspend/resume?
>
> Does the BUG still appear if we changed BUG_ON line to BUG_ON(dev->mode !=
> CLOCK_EVT_MODE_UNUSED && dev->mode != CLOCK_EVT_MODE_SHUTDOWN)?

I only see the BUG on halt - reboot works normally and suspend
actually freezes and doesn't suspend, but that's perhaps unrelated.

I managed to get your suggested printk to work by adding KERN_CRIT
(otherwise I got no output), and the offending dev is:
 "hpet", mode 3 (CLOCK_EVT_MODE_ONESHOT?), cpu 4.

Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/