Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932584Ab0AGDFs (ORCPT ); Wed, 6 Jan 2010 22:05:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932356Ab0AGDFr (ORCPT ); Wed, 6 Jan 2010 22:05:47 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:39924 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932349Ab0AGDFr (ORCPT ); Wed, 6 Jan 2010 22:05:47 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Thu, 7 Jan 2010 12:02:33 +0900 From: KAMEZAWA Hiroyuki To: Daisuke Nishimura Cc: Randy Dunlap , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: mmotm 2010-01-06-14-34 uploaded (mm/memcontrol) Message-Id: <20100107120233.f244d4b7.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100107115901.594330d0.nishimura@mxp.nes.nec.co.jp> References: <201001062259.o06MxQrp023236@imap1.linux-foundation.org> <20100106171058.f1d6f393.randy.dunlap@oracle.com> <20100107111319.7d95fe86.nishimura@mxp.nes.nec.co.jp> <20100107112150.2e585f1c.kamezawa.hiroyu@jp.fujitsu.com> <20100107115901.594330d0.nishimura@mxp.nes.nec.co.jp> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1958 Lines: 54 On Thu, 7 Jan 2010 11:59:01 +0900 Daisuke Nishimura wrote: > Thank you for your fix. > > On Thu, 7 Jan 2010 11:21:50 +0900, KAMEZAWA Hiroyuki wrote: > > On Thu, 7 Jan 2010 11:13:19 +0900 > > Daisuke Nishimura wrote: > > > > > Thank you for your report. > > > > > > config attached. > > > > > > > I'm sorry I missed the !CONFIG_SWAP or !CONFIG_CGROUP_MEM_RES_CTLR_SWAP case. > > > > > > I'll prepare fixes. > > > > > Nishimura-san, could you double check this ? > > > It seems that this cannot fix the !CONFIG_SWAP case in my environment. > > > Andrew, this is a fix onto Nishimura-san's memcg move account patch series. > > Maybe this -> patches/memcg-move-charges-of-anonymous-swap.patch > > > I think both memcg-move-charges-of-anonymous-swap.patch and > memcg-improve-performance-in-moving-swap-charge.patch need to be fixed. > > > mm/memcontrol.c: In function 'is_target_pte_for_mc': > > mm/memcontrol.c:3985: error: implicit declaration of function 'mem_cgroup_count_swap_user' > This derives from a bug of memcg-move-charges-of-anonymous-swap.patch, > > and > > > mm/memcontrol.c: In function 'mem_cgroup_move_charge_pte_range': > > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account' > > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account' > > mm/memcontrol.c:4220: error: too many arguments to function 'mem_cgroup_move_swap_account' > this derives from that of memcg-improve-performance-in-moving-swap-charge.patch. > > > I'm now testing my patch in some configs, and will post later. > Okay, plz. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/