DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=fW1Wb3gBNY/0fqC61so1wpoocCB2AoewrKvUkqL84+Fig+sU4A+3FyBXK6AomzNlyt
         T/LyOSqJJ5gH2eiFJKePshBYAoqOTOfhvPWSIYjBjHuu0q2Qge8xEy3nENQOfa7sLxBc
         GHoSP348mH2kgZMB28SiZmuO8R/G+/2LMD38Q=
MIME-Version: 1.0
In-Reply-To: <adaeim2supb.fsf_-_@roland-alpha.cisco.com>
References: <ada3a2jugqu.fsf@roland-alpha.cisco.com>
	 <20100106123306.ac85e557.akpm@linux-foundation.org>
	 <aday6kbt14a.fsf@roland-alpha.cisco.com>
	 <20100106134232.0025e818.akpm@linux-foundation.org>
	 <adaeim2supb.fsf_-_@roland-alpha.cisco.com>
Date: Thu, 7 Jan 2010 08:33:21 +0100
Message-ID: <e2e108261001062333p2a626bf6h4b25de0ac919ef1d@mail.gmail.com>
Subject: Re: [PATCH] Add BUILD_BUG_ON_NOT_POWER_OF_2()
From: Bart Van Assche <bvanassche@acm.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       David Dillow <dave@thedillows.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 753
Lines: 19

On Thu, Jan 7, 2010 at 12:02 AM, Roland Dreier <rdreier@cisco.com> wrote:
> +/* Force a compilation error if expression is not a power of 2 */
> +#define BUILD_BUG_ON_NOT_POWER_OF_2(n) ? ? ? ? ? ? ? ? \
> + ? ? ? BUILD_BUG_ON(((n) != 0 && (((n) & ((n) - 1)) == 0)))

Hello Roland,

Can you please change the above into the following, such that the
macro does what its name suggests:

#define BUILD_BUG_ON_NOT_POWER_OF_2(n)                 \
       BUILD_BUG_ON(((n) == 0 || (((n) & ((n) - 1)) != 0)))

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/