Date: Thu, 07 Jan 2010 01:02:01 -0800 (PST)
Message-Id: <20100107.010201.51693251.davem@davemloft.net>
To: mpm@selenic.com
Cc: danborkmann@googlemail.com, linux-kernel@vger.kernel.org,
       jmoyer@redhat.com, netdev@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per
 interface
From: David Miller <davem@davemloft.net>
In-Reply-To: <1262836445.29868.227.camel@calx>
References: <4B44F895.9080205@gmail.com>
	<1262836445.29868.227.camel@calx>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 670
Lines: 22

From: Matt Mackall <mpm@selenic.com>
Date: Wed, 06 Jan 2010 21:54:05 -0600

> Please inline patches so they can be reviewed easily in reply.
> 
> 
> -       struct netpoll *np = npi->rx_np;
> +       struct netpoll **np = &npi->rx_np;
>  
> -       if (!np)
> +       if (!(*np))
> 
> This makes everything horrible. Can you avoid the double indirection?
> Using a list head might be a good answer.
> 

Agreed on all counts.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/