Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847Ab0AGVgS (ORCPT ); Thu, 7 Jan 2010 16:36:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752794Ab0AGVgR (ORCPT ); Thu, 7 Jan 2010 16:36:17 -0500 Received: from mail.perches.com ([173.55.12.10]:1625 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799Ab0AGVgR (ORCPT ); Thu, 7 Jan 2010 16:36:17 -0500 Subject: Re: [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses From: Joe Perches To: =?UTF-8?Q?Micha=C5=82_Miros=C5=82aw?= Cc: H Hartley Sweeten , David Miller , "Maciej W. Rozycki" , linux-kernel@vger.kernel.org, netdev In-Reply-To: References: <1262888625.10429.23.camel@Joe-Laptop.home> Content-Type: text/plain; charset="UTF-8" Date: Thu, 07 Jan 2010 13:36:15 -0800 Message-ID: <1262900175.10429.75.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 539 Lines: 14 On Thu, 2010-01-07 at 22:18 +0100, Michał Mirosław wrote: > Something like the following might be smaller and faster - no > functions and their calls > int rev = (fmt[1] == 'F'); > p = pack_hex_byte(p, rev ? bitrev8(addr[i]) : addr[i]); Right, better. Just 6 bytes (x86). Resubmitting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/