Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344Ab0AGWJh (ORCPT ); Thu, 7 Jan 2010 17:09:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753703Ab0AGWJg (ORCPT ); Thu, 7 Jan 2010 17:09:36 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42318 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651Ab0AGWJg (ORCPT ); Thu, 7 Jan 2010 17:09:36 -0500 Date: Thu, 07 Jan 2010 14:09:42 -0800 (PST) Message-Id: <20100107.140942.135976087.davem@davemloft.net> To: macro@linux-mips.org Cc: joe@perches.com, hartleys@visionengravers.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses From: David Miller In-Reply-To: References: <1262888625.10429.23.camel@Joe-Laptop.home> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 19 From: "Maciej W. Rozycki" Date: Thu, 7 Jan 2010 20:42:12 +0000 (GMT) > What's the gain? I'd be rather conservative when taking everybody's 56 > bytes for one or two drivers hardly anybody uses. The format of MAC > addresses is unlikely to change, so I'd say the sources can live with > one or two places where the strings are formatted manually. Even if the > drivers lose more than these 56 bytes. We gain consistency. You know, the part that's completely bolixed right now? I'm applying Joe's patch and followon patches to make the driver's use the new printf format. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/