DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=c3cx/AopQamG0he7Pj7F59RLCmIDgX8LMeZbswZsBs+oSqXc3kbNjeJJaKqlthyxi9
         V4QwwPtkzq2Qb1wlEcOyip8UJcmM8XQ8N/6gTM7vNo53R26hqmTRoVZp04VCZ2Zt/r2A
         2Y2bkodVvtyXpJiwkhlbHuNb5HKKmthHyuce0=
MIME-Version: 1.0
In-Reply-To: <20100107212912.GB10344@brick.ozlabs.ibm.com>
References: <1262882447-23776-1-git-send-email-a.beregalov@gmail.com>
	 <20100107212912.GB10344@brick.ozlabs.ibm.com>
Date: Fri, 8 Jan 2010 01:44:59 +0300
Message-ID: <a4423d671001071444k2cb61c0blb1bb175ab0098a9f@mail.gmail.com>
Subject: Re: [PATCH 1/2] perf: add close()/closedir() calls when needed
From: Alexander Beregalov <a.beregalov@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 662
Lines: 15

2010/1/8 Paul Mackerras <paulus@samba.org>:
> On Thu, Jan 07, 2010 at 07:40:46PM +0300, Alexander Beregalov wrote:
>
>> Close file and directory descriptors before exiting or dying.
>
> Your patch description doesn't say why that's a good thing to do, and
> it's not obvious to me at least.  Please explain the motivation in
> your patch description.

Isn't it a good style to close files after use and before exit?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/