Subject: Re: [GIT PULL] Please pull NFS client bugfixes....
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org
In-Reply-To: <20100108004513.GF16076@basil.fritz.box>
References: <1262896174.2659.3.camel@localhost>
	 <87zl4pmxzp.fsf@basil.nowhere.org> <1262901198.2659.38.camel@localhost>
	 <20100107235149.GD16076@basil.fritz.box>
	 <1262909682.2659.45.camel@localhost>
	 <alpine.LFD.2.00.1001071633200.7821@localhost.localdomain>
	 <20100108004513.GF16076@basil.fritz.box>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Organization: NetApp
Date: Thu, 07 Jan 2010 20:03:37 -0500
Message-ID: <1262912617.2659.90.camel@localhost>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 674
Lines: 19

On Fri, 2010-01-08 at 01:45 +0100, Andi Kleen wrote: 
> > If that is ok, then why do the revalidate at all? Just do the open/close 
> > consistency and validate at open time, not mmap time.
> 
> That's exactly what my patch does :)

Actually, it doesn't....

It does remove the validation at mmap time, but it adds nothing at open
time to ensure that we call nfs_revalidate_mapping().

...and as I said, it breaks 'noac'.

Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/