Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313Ab0AHCLk (ORCPT ); Thu, 7 Jan 2010 21:11:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753284Ab0AHCLi (ORCPT ); Thu, 7 Jan 2010 21:11:38 -0500 Received: from exprod6og107.obsmtp.com ([64.18.1.208]:34765 "HELO exprod6og107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750983Ab0AHCLh convert rfc822-to-8bit (ORCPT ); Thu, 7 Jan 2010 21:11:37 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: RE: [PATCH] drivers/net/defxx.c: use %pMF to show MAC address Date: Thu, 7 Jan 2010 21:11:34 -0500 Message-ID: In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] drivers/net/defxx.c: use %pMF to show MAC address Thread-Index: AcqQByo2d3IyWpHBTQ+Z2QITGltPXQAACpzQ References: <201001071624.20139.hartleys@visionengravers.com> <1262914750.10429.88.camel@Joe-Laptop.home> From: "H Hartley Sweeten" To: "Maciej W. Rozycki" , "Joe Perches" Cc: "Linux Kernel" , , X-OriginalArrivalTime: 08 Jan 2010 02:11:36.0023 (UTC) FILETIME=[E7B7BE70:01CA9007] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2007 Lines: 50 On Thursday, January 07, 2010 7:06 PM, Maciej W. Rozycki wrote: > On Thu, 7 Jan 2010, Joe Perches wrote: > >> On Thu, 2010-01-07 at 16:24 -0700, H Hartley Sweeten wrote: >>> Use the %pMF kernel extension to display the MAC address. >>> The address will still be displayed in the FDDI Canonical format. >> >>> diff --git a/drivers/net/defxx.c b/drivers/net/defxx.c >>> index 6a6ea03..e4eac4b 100644 >>> --- a/drivers/net/defxx.c >>> +++ b/drivers/net/defxx.c >>> @@ -1052,12 +1052,9 @@ static int __devinit dfx_driver_init(struct net_device *dev, >>> board_name = "DEFEA"; >>> if (dfx_bus_pci) >>> board_name = "DEFPA"; >>> - pr_info("%s: %s at %saddr = 0x%llx, IRQ = %d, " >>> - "Hardware addr = %02X-%02X-%02X-%02X-%02X-%02X\n", >>> + pr_info("%s: %s at %saddr = 0x%llx, IRQ = %d, Hardware addr = %pMF\n", >>> print_name, board_name, dfx_use_mmio ? "" : "I/O ", >> >> I believe the output will _now_ be in the canonical form. >> Before it wasn't bit reversed. Now it should be. > > Output was correct -- why would you assume otherwise? The bit order in > the MLA (My Long Address) register as retrieved from the MAC chip by > board's firmware has nothing to do with the wire order and is already in > the canonical form (the same applies to CAM entries and frame headers) -- > the board designers were sane people. > > With the two patches in place the output produced is now broken. :( > Ugh.. This is a mess... David, Can you please un-apply both this patch and the one for skfddi.c? I think they should both use some form of the %p[mMF] format to display the address but it appears Maciej is the only person that really knows what the output _should" be... Oh well... So much for trying to make things consistent... Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/