Subject: Re: [PATCH] gpio: introduce gpio_request_one() and friends
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Ben Nizette <bn@niasdigital.com>
In-Reply-To: <f17812d71001072114g95c267cpa6dc06a636c6d9a@mail.gmail.com>
Date: Fri, 8 Jan 2010 17:08:28 +1100
Cc: David Brownell <david-b@pacbell.net>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@osdl.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <A780F468-EA15-49EA-83B4-D472E92CA91A@niasdigital.com>
References: <f17812d71001072114g95c267cpa6dc06a636c6d9a@mail.gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1231
Lines: 25


On 08/01/2010, at 4:14 PM, Eric Miao wrote:

> commit 29cd35f57699fd93a12132186d52109a55ed57e7
> Author: Eric Miao <eric.y.miao@gmail.com>
> Date:   Fri Jan 8 12:16:28 2010 +0800
> 
>    gpio: introduce gpio_request_one() and friends
> 
>    gpio_request() without initial configuration of the GPIO is normally
>    useless, introduce gpio_request_one() together with GPIOF_ flags for
>    input/output direction and initial output level.

Well yea it is useless without initial configuration but I've always done that configuration before any gpiolib calls.  The initial direction and state stuff really has to be set up and pin-mux or gpio-chip-activate time otherwise it'll glitch; by the time we get to gpio_request time I've got everything just how I like it and just want the refcount aspect of gpio_request.

I'm obviously thinking in a very small-minded platform-gpio-only kind of a way, what system have you got which uses this (and how does it not glitch)?

Thanks,
	--Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/