DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=FE+RqSPblr/MQUUVA2UCGRraWnZs4M0VOnKybt4qspfetMI1WwX+2Z6+UMPDBgwBQc
         ujvOHe2sVYtL+1kexFzetzmF+1JyBQ3naAGrvAiJq+tNS6Q+bO0NuZVkshG04MfigQjw
         LsFxFayi2sR0V+Jzz9kmdStqaYGuzsF2pq+YM=
MIME-Version: 1.0
In-Reply-To: <20100107143651.2fa73662.randy.dunlap@oracle.com>
References: <201001072218.o07MIPNm020870@imap1.linux-foundation.org>
	 <20100107143651.2fa73662.randy.dunlap@oracle.com>
Date: Fri, 8 Jan 2010 12:34:15 +0600
Message-ID: <b9df5fa11001072234o2e5fb8bfv7b57a562d9a6e4d1@mail.gmail.com>
Subject: Re: + hugetlb-fix-section-mismatch-warning-in-hugetlbc.patch added to 
	-mm tree
From: Rakib Mullick <rakib.mullick@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
       akpm@linux-foundation.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1399
Lines: 42

On 1/8/10, Randy Dunlap <randy.dunlap@oracle.com> wrote:

Hi,
>
> Hi,
>
>  If so, then hugetlb_register_node() could be called at any time
>  (like after system init), and it would then call
>  hugetlb_sysfs_add_hstate(), which would be bad.
>
But - hugetlb_register_node is only called from hugetlb_register_all_nodes.
The call sequence is :
                    hugetlb_init   --------------->  was __init
                         \-> hugetlb_register_all_nodes  ----> we make it __init
                                          \-> hugetlb_register_node
---> we make it __init
                                                 \->
hugetlb_sysfs_add_hstate -> this was __init

Above all happens in __init context. So - hugetlb_register_node is
called only at
system init. But I don't think __init is used for hotplug support, for
proper hotplug
support we might use __meminit.

And register_hugetlbfs_with_node is called from hugetlb_un/register_node.
But hugetlb_unregister_node doesn't use callback function. It's not referencing
hugetlb_sysfs_add_hstate(). So - it's safe. Unless I'm not missing
anything, too.

thanks,

>  Thanks.
> ---
>
> ~Randy
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/