Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299Ab0AHICo (ORCPT ); Fri, 8 Jan 2010 03:02:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753266Ab0AHICk (ORCPT ); Fri, 8 Jan 2010 03:02:40 -0500 Received: from ns.dcl.info.waseda.ac.jp ([133.9.216.194]:62425 "EHLO ns.dcl.info.waseda.ac.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753171Ab0AHICj (ORCPT ); Fri, 8 Jan 2010 03:02:39 -0500 Message-ID: <4B46E69D.9050800@dcl.info.waseda.ac.jp> Date: Fri, 08 Jan 2010 17:02:37 +0900 From: Hitoshi Mitake User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091211 Shredder/3.0 MIME-Version: 1.0 To: Peter Zijlstra CC: Ingo Molnar , linux-kernel@vger.kernel.org, Paul Mackerras , Frederic Weisbecker Subject: Re: [PATCH] perf lock: Implement basic sorting function of perf lock References: <1261277805-27023-1-git-send-email-mitake@dcl.info.waseda.ac.jp> <1261995437.7135.54.camel@laptop> In-Reply-To: <1261995437.7135.54.camel@laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 20 On 2009年12月28日 19:17, Peter Zijlstra wrote: > On Sun, 2009-12-20 at 11:56 +0900, Hitoshi Mitake wrote: >> +/* based on kernel/lockdep.c */ >> +#define MAX_LOCKDEP_KEYS_BITS 13 >> +#define LOCKHASH_BITS (MAX_LOCKDEP_KEYS_BITS - 1) >> +#define LOCKHASH_SIZE (1UL<< LOCKHASH_BITS) > > Since you're hashing something fundamentally different than lockdep does > I don't think it makes sense to carry either the name or the size along. > > Do you mean that MAX_LOCKDEP_KEYS_BITS is needless? # Sorry, I'm not good at English... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/