Message-ID: <4B46E70A.7090205@dcl.info.waseda.ac.jp>
Date: Fri, 08 Jan 2010 17:04:26 +0900
From: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091211 Shredder/3.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>
CC: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       Paul Mackerras <paulus@samba.org>,
       Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] perf lock: Implement basic sorting function of perf lock
References: <1261277805-27023-1-git-send-email-mitake@dcl.info.waseda.ac.jp> <1261997898.7135.72.camel@laptop>
In-Reply-To: <1261997898.7135.72.camel@laptop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1274
Lines: 31

On 2009年12月28日 19:58, Peter Zijlstra wrote:
> On Sun, 2009-12-20 at 11:56 +0900, Hitoshi Mitake wrote:
>> +#define SINGLE_KEY(member)                                     \
>> +       static int lock_stat_key_ ## member(struct lock_stat *one,      \
>> +                                        struct lock_stat *two)         \
>> +       {                                                               \
>> +       if (one->member>  two->member)                                  \
>> +               return 1;                                               \
>> +       else                                                            \
>> +               return 0;                                               \
>> +       }
>
> Seems to me:
>
> 	return one->member>  two->member;
>
> Should suffice, no?
>
> [ I usually call the arguments to a comparator (l)eft/(r)ight or a/b,
>    but I guess one/two works too :-) ]
>
>

Yeah, your way is far smarter than mine :)
Body of this function can be in single line, I'll fix.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/