Return-Path: <linux-kernel-owner+w=401wt.eu-S1752245Ab0AHIxM@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752245Ab0AHIxM (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jan 2010 03:53:12 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751489Ab0AHIxK
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 8 Jan 2010 03:53:10 -0500
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37083
	"EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751449Ab0AHIxI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jan 2010 03:53:08 -0500
Date: Fri, 08 Jan 2010 00:53:14 -0800 (PST)
Message-Id: <20100108.005314.32731548.davem@davemloft.net>
To: hartleys@visionengravers.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       buytenh@wantstofly.org
Subject: Re: [PATCH] ep93xx_eth.c general cleanup
From: David Miller <davem@davemloft.net>
In-Reply-To: <201001051405.31782.hartleys@visionengravers.com>
References: <201001051405.31782.hartleys@visionengravers.com>
X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1456
Lines: 32

From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Tue, 5 Jan 2010 14:05:31 -0700

> General cleanup of the ep93xx_eth driver.
> 
> 1) Use pr_fmt() to prefix the module name and __func__ to the error 
>    messages.
> 2) <linux/io.h> instead of <asm/io.h>
> 3) <mach/hardware.h> instead of <mach/ep93xx-regs.h> and <mach/platform.h>
> 4) Move the ep93xx_mdio_read (and ep93xx_mdio_write) function to eliminate
>    the function prototype.
> 5) Change all the printk(<level> messages to pr_<level> and remove the 
>    __func__ argument.
> 6) Use platform_get_{resource/irq} to get the platform resources and add
>    an error check.
> 7) Use resource_size() for request_mem_region() and ioremap().
> 8) Use %pM to print the MAC address at the end of the probe.
> 9) Use dev->dev_addr not data->dev_addr for the MAC argument because a
>    random address could be used if the platform does not supply one.
> 
> The message at the end of the probe is left as a printk since it displays
> cleaner without the function name that would be displayed with pr_info().
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Acked-by: Lennert Buytenhek <kernel@wantstofly.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/