From: "Zhang, Xiantao" <xiantao.zhang@intel.com>
To: Gabor Gombas <gombasg@sztaki.hu>
CC: Roel Kluin <roel.kluin@gmail.com>,
       "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Date: Fri, 8 Jan 2010 17:14:25 +0800
Subject: RE: [PATCH] KVM: dereference of NULL pointer in set_pal_result()
Thread-Topic: [PATCH] KVM: dereference of NULL pointer in set_pal_result()
Thread-Index: AcqQMeNH9yyhCx5aQr2vdQpCo80pMQAEPa8A
Message-ID: <EB8593BCECAB3D40A8248BE0B6400A38318A1443@shzsmsx502.ccr.corp.intel.com>
References: <4B465C2D.8030303@gmail.com>
 <EB8593BCECAB3D40A8248BE0B6400A38315E5831@shzsmsx502.ccr.corp.intel.com>
 <20100108071200.GB15621@boogie.lpds.sztaki.hu>
In-Reply-To: <20100108071200.GB15621@boogie.lpds.sztaki.hu>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 33

Gabor Gombas wrote:
> On Fri, Jan 08, 2010 at 07:28:57AM +0800, Zhang, Xiantao wrote:
> 
>> For the check "(p && p->exit_reason == EXIT_REASON_PAL_CALL", if p
>> is NULL, the reference about "p->exit_reason ==
>> EXIT_REASON_PAL_CALL" won't be checked any more, so no issue here.  
> 
>>> diff --git a/arch/ia64/kvm/kvm_fw.c b/arch/ia64/kvm/kvm_fw.c
>>> index e4b8231..d28494f 100644
>>> --- a/arch/ia64/kvm/kvm_fw.c
>>> +++ b/arch/ia64/kvm/kvm_fw.c
>>> @@ -75,9 +75,11 @@ static void set_pal_result(struct kvm_vcpu
>>> *vcpu,  	struct exit_ctl_data *p; 
>>> 
>>>  	p = kvm_get_exit_data(vcpu);
>>> -	if (p && p->exit_reason == EXIT_REASON_PAL_CALL) { +	if (!p)
>>> +		return;
>>> +	if (p->exit_reason == EXIT_REASON_PAL_CALL) {
>>>  		p->u.pal_data.ret = result;
>>> -		return ;
>>> +		return;
>>>  	}
>>>  	INIT_PAL_STATUS_UNIMPLEMENTED(p->u.pal_data.ret);
> 
> IMHO it's not the test but the INIT_PAL_STATUS_UNIMPLEMENTED() that
> does the unwanted dereferencing, and that's fixed by the patch.
Make sense. 
Xiantao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/