Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980Ab0AHNeo (ORCPT ); Fri, 8 Jan 2010 08:34:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752662Ab0AHNen (ORCPT ); Fri, 8 Jan 2010 08:34:43 -0500 Received: from eddie.linux-mips.org ([78.24.191.182]:41504 "EHLO eddie.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116Ab0AHNem (ORCPT ); Fri, 8 Jan 2010 08:34:42 -0500 Date: Fri, 8 Jan 2010 13:34:34 +0000 (GMT) From: "Maciej W. Rozycki" To: H Hartley Sweeten cc: Joe Perches , Linux Kernel , netdev@vger.kernel.org, davem@davemloft.net Subject: RE: [PATCH] drivers/net/defxx.c: use %pMF to show MAC address In-Reply-To: Message-ID: References: <201001071624.20139.hartleys@visionengravers.com> <1262914750.10429.88.camel@Joe-Laptop.home> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2050 Lines: 49 On Thu, 7 Jan 2010, H Hartley Sweeten wrote: > >> I believe the output will _now_ be in the canonical form. > >> Before it wasn't bit reversed. Now it should be. > > > > Output was correct -- why would you assume otherwise? The bit order in > > the MLA (My Long Address) register as retrieved from the MAC chip by > > board's firmware has nothing to do with the wire order and is already in > > the canonical form (the same applies to CAM entries and frame headers) -- > > the board designers were sane people. > > > > With the two patches in place the output produced is now broken. :( > > > > Ugh.. This is a mess... > > David, > > Can you please un-apply both this patch and the one for skfddi.c? > I think they should both use some form of the %p[mMF] format to display > the address but it appears Maciej is the only person that really knows > what the output _should" be... Here are excerpts from old bootstrap logs -- I don't have any of these boards handy at the moment, but I'll have access to a couple in a few weeks' time: defxx: v1.10 2006/12/14 Lawrence V. Stefani and others tc0: DEFTA at addr = 0x10100000, IRQ = 2, Hardware addr = 08-00-2B-A3-66-C8 tc0: registered as fddi0 tc1: DEFTA at addr = 0x14100000, IRQ = 3, Hardware addr = 08-00-2B-A3-A3-29 tc1: registered as fddi1 defxx: v1.10 2006/12/14 Lawrence V. Stefani and others 0000:00:06.0: DEFPA at addr = 0x41071000, IRQ = 57, Hardware addr = 00-60-B0-58-40-75 0000:00:06.0: registered as fddi0 0000:02:00.0: DEFPA at addr = 0x41510000, IRQ = 57, Hardware addr = 00-60-B0-58-41-E7 0000:02:00.0: registered as fddi1 Compare the addresses reported with the OUIs of the respective manufacturers -- the former is DEC and the latter is HP. See http://standards.ieee.org/regauth/oui/oui.txt for a reference. Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/