From: Arnd Bergmann <arnd@arndb.de>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: compat_ioctl: unknown cmd on serial /dev/console
Date: Fri, 8 Jan 2010 17:18:23 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; x86_64; ; )
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>, linux-kernel@vger.kernel.org
References: <20100109.000510.193873785.anemo@mba.ocn.ne.jp>
In-Reply-To: <20100109.000510.193873785.anemo@mba.ocn.ne.jp>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201001081718.23840.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1794
Lines: 47

On Friday 08 January 2010, Atsushi Nemoto wrote:
> After the commit fb07a5f8 ("compat_ioctl: remove all VT ioctl
> handling"), I got this error message on 64-bit mips kernel with 32-bit
> busybox userland:
> 
> ioctl32(init:1): Unknown cmd fd(0) cmd(00005600){t:'V';sz:0} arg(7fd76480) on /dev/console

Just to confirm: The behaviour of the kernel is still correct, it's only
the message you are worried about, right?

Sorry for this, it will be trivial to fix.

> The cmd 5600 is VT_OPENQRY.  The busybox's init issues this ioctl to
> know vt-console or serial-console.  If the console was serial console,
> VT ioctls are not handled by the serial driver.
> 
> How this error should be fixed?  Is this patch OK?
> 
> diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
> index 332dd00..731478f 100644
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -1005,6 +1005,8 @@ COMPATIBLE_IOCTL(SCSI_IOCTL_SEND_COMMAND)
>  COMPATIBLE_IOCTL(SCSI_IOCTL_PROBE_HOST)
>  COMPATIBLE_IOCTL(SCSI_IOCTL_GET_PCI)
>  #endif
> +/* Big V (for serial console case) */
> +COMPATIBLE_IOCTL(VT_OPENQRY)
>  /* Little p (/dev/rtc, /dev/envctrl, etc.) */
>  COMPATIBLE_IOCTL(RTC_AIE_ON)
>  COMPATIBLE_IOCTL(RTC_AIE_OFF)

I would probably write this as IGNORE_IOCTL() instead of COMPATIBLE_IOCTL
in order to document the intent, but it's functionally the same.

> And by quick search, I found some programs using VT_GETMODE to check
> vt-console is available or not.  So VT_GETMODE might be an another
> candidate, but not sure.

Yes, that sounds reasonable, too.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/