DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=pYKNYbFyFTn+putqKosByNJrZV3a9xSzv4Yp1j0hF49S2Ze0cm9TR/nvyMDYF2Srb6WPXjS+8UiCT3umrKOqF5QmUIIssaQ15fCQKgbxywhg9s8IHBrOWGHQiwbBhRhP;
Date: Fri, 8 Jan 2010 17:13:11 -0800
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Eric Anholt <eric@anholt.net>,
       Zhenyu Wang <zhenyuw@linux.intel.com>,
       LKML <linux-kernel@vger.kernel.org>,
       pm list <linux-pm@lists.linux-foundation.org>,
       dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o
 KMS
Message-ID: <20100108171311.128c43d0@jbarnes-piketon>
In-Reply-To: <alpine.LFD.2.00.1001081648490.7821@localhost.localdomain>
References: <201001090045.33784.rjw@sisk.pl>
	<alpine.LFD.2.00.1001081548320.7821@localhost.localdomain>
	<20100108163217.341da699@jbarnes-piketon>
	<201001090146.17793.rjw@sisk.pl>
	<alpine.LFD.2.00.1001081648490.7821@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1121
Lines: 33

On Fri, 8 Jan 2010 16:50:57 -0800 (PST)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Sat, 9 Jan 2010, Rafael J. Wysocki wrote:
> > 
> > Which is functionally equivalent to my patch, because
> > i915_suspend/resume() won't be called by drm_class_suspend/resume()
> > in the KMS case anyway.
> 
> Ahh, right you are - that class suspend function does a check for 
> DRIVER_MODESET, and only does the suspend/resume if it's not a
> MODESET driver.
> 
> Ok, so I withdraw my objections to your original patch - it's
> confusing, but that's just because DRM is such a horrible mess with
> subtle things.

Yeah the non-KMS paths just suck.

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Though hopefully you can get the PCI driver registration working w/o
too much trouble; that would be even better.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/