Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754471Ab0AICn7 (ORCPT ); Fri, 8 Jan 2010 21:43:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754215Ab0AICn6 (ORCPT ); Fri, 8 Jan 2010 21:43:58 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:43905 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754208Ab0AICn5 (ORCPT ); Fri, 8 Jan 2010 21:43:57 -0500 Date: Sat, 9 Jan 2010 02:43:53 +0000 From: Al Viro To: Linus Torvalds Cc: Trond Myklebust , Andi Kleen , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [RFC PATCH 0/2] Fix up the NFS mmap code Message-ID: <20100109024353.GJ30528@ZenIV.linux.org.uk> References: <1262913974.2659.101.camel@localhost> <20100109005624.7473.33215.stgit@localhost.localdomain> <20100109013825.GD30528@ZenIV.linux.org.uk> <20100109021124.GG30528@ZenIV.linux.org.uk> <20100109023035.GH30528@ZenIV.linux.org.uk> <20100109024005.GI30528@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100109024005.GI30528@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 17 On Sat, Jan 09, 2010 at 02:40:05AM +0000, Al Viro wrote: > On Sat, Jan 09, 2010 at 02:30:35AM +0000, Al Viro wrote: > > > Interesting... There's nfs_update_inode(), but it ought to scream bloody > > murder on the type change (and its return value is ignore by nfs_fhget(), > > BTW). > > Uh-oh... Just what will happen if we get FATTR_MODE without FATTR_TYPE, > BTW? AFAICS, the check for changed type won't trigger, but we will > get type bits in i_mode set to 0. Probably unrelated, but... Definitely unrelated - we'll get i_mode buggered, but i_op remains set. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/