Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 11 Apr 2002 13:58:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 11 Apr 2002 13:58:29 -0400 Received: from perninha.conectiva.com.br ([200.250.58.156]:54800 "HELO perninha.conectiva.com.br") by vger.kernel.org with SMTP id ; Thu, 11 Apr 2002 13:58:29 -0400 Date: Thu, 11 Apr 2002 14:58:07 -0300 (BRT) From: Rik van Riel X-X-Sender: riel@duckman.distro.conectiva To: Tom Rini Cc: Marcelo Tosatti , Subject: Re: [PATCH] remove compiler.h from mmap.c In-Reply-To: <20020411175126.GE19157@opus.bloom.county> Message-ID: X-spambait: aardvark@kernelnewbies.org X-spammeplease: aardvark@nl.linux.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Apr 2002, Tom Rini wrote: > On Thu, Apr 11, 2002 at 02:37:23PM -0300, Rik van Riel wrote: > > > compiler.h is included via other include files now and its > > #include has been removed from most C files, this patch > > finishes the job for mm/* > > What #include file is mm/mmap.c getting from now? slab.h -> mm.h -> sched.h -> kernel.h -> compiler.h > Hiding (or relying on indirect) #includes isn't always a good thing... Absolutely agreed, but likely/unlikely is such low-level stuff that it shouldn't be included directly into .c files, IMHO. regards, Rik -- Will hack the VM for food. http://www.surriel.com/ http://distro.conectiva.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/