DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=rEESUrRemDqeJPL9EAbruUxxusAcN/txnSYJvGT2421++lWcQreLufzeQTCujNXvAf
         dj3fgTtQvACT80eCh8TdFnxfhZitgPu4mDs+L4nDsGasG3aaGWPOFLOK8ZdMpbUdbYRl
         MzehFZXDSfXaaj+nfSqGbF+UnQF89vUe7bwHQ=
MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.00.1001091608230.7275@pobox.suse.cz>
References: <4B489B44.50101@gmail.com> <alpine.LNX.2.00.1001091608230.7275@pobox.suse.cz>
From: roel kluin <roel.kluin@gmail.com>
Date: Sat, 9 Jan 2010 19:51:21 +0100
Message-ID: <25e057c01001091051q7c09ed40u6a860adee6a750d4@mail.gmail.com>
Subject: Re: HID: is scancode correctly reported after key status change in 
	hidinput_hid_event()?
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1321
Lines: 34

On Sat, Jan 9, 2010 at 4:15 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Sat, 9 Jan 2010, Roel Kluin wrote:
>
>> vi drivers/hid/hid-input.c +634 and not in hidinput_hid_event()
>>
>>       /* report the usage code as scancode if the key status has changed */
>>       if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
>>               input_event(input, EV_MSC, MSC_SCAN, usage->hid);
>>
>> Only if value is 1 or 0 the input_event() can occur, but value doesn't
>> seem to be intended to be used as a boolean. are we really doing the
>> correct test here?
>
> Hi Roel,
>
> well, value 2 means 'repeated' key, and there is no other possibility for
> EV_KEY value than 0,1,2.
>
> For EV_KEY events generated by HID devices, the autorepeat is done by
> input core (as the device sends the report only when status is changed),
> so there is no easy way how to inject EV_MSC into the 'autorepeat reports'
> anyway.
>
> Are you hitting some bug because of this, or have you found this out
> solely by code reading?

only code reading.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/