Date: Sat, 9 Jan 2010 15:43:05 -0800
From: Greg KH <gregkh@suse.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: =?iso-8859-1?Q?N=E9meth_M=E1rton?= <nm127@freemail.hu>,
       devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
       Julia Lawall <julia@diku.dk>, cocci@diku.dk
Subject: Re: [PATCH 1/3] staging: make PCI device id constant
Message-ID: <20100109234304.GA6168@suse.de>
References: <4B490EC2.7050703@freemail.hu>
 <20100109154115.152c55e1@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20100109154115.152c55e1@infradead.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 795
Lines: 25

On Sat, Jan 09, 2010 at 03:41:15PM -0800, Arjan van de Ven wrote:
> On Sun, 10 Jan 2010 00:18:26 +0100
> N?meth M?rton <nm127@freemail.hu> wrote:
> 
> > From: M?rton N?meth <nm127@freemail.hu>
> > 
> > The id_table field of the struct pci_driver is constant in
> > <linux/pci.h> so it is worth to make the initialization data also
> > constant.
> 
> 
> the PCI ID table can get written too via sysfs... making it const
> breaks that...

It shouldn't, I thought that was what we used the dynids field in the
pci_driver structure :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/