Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476Ab0AJCAf (ORCPT ); Sat, 9 Jan 2010 21:00:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754456Ab0AJCAd (ORCPT ); Sat, 9 Jan 2010 21:00:33 -0500 Received: from one.firstfloor.org ([213.235.205.2]:59097 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754454Ab0AJCAb (ORCPT ); Sat, 9 Jan 2010 21:00:31 -0500 Date: Sun, 10 Jan 2010 03:00:17 +0100 From: Andi Kleen To: Trond Myklebust Cc: Andi Kleen , Linus Torvalds , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [RFC PATCH 0/2] Fix up the NFS mmap code Message-ID: <20100110020015.GA25323@basil.fritz.box> References: <1262913974.2659.101.camel@localhost> <20100109005624.7473.33215.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100109005624.7473.33215.stgit@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 17 On Fri, Jan 08, 2010 at 07:56:24PM -0500, Trond Myklebust wrote: > How about something like the following. I chose to wrap the call to > do_mmap_pgoff() instead of making a special ->pre_mmap(), since that > seems more consistent with the way we handle ->read() and ->write(). I tested the patch and I don't see the lockdep problem anymore and seems to work so far on the test system with some quick tests. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/