DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=vDuQChEgLw5zeNlDCSMIeCZF3UtkCD75PWCmxf4z3ULzlVbWALm32lk2KNkg/uRVck
         V39pWm1jExy8rGCyXRA78FkJJeJl0FZxSlZgtNibzWEFg8yONmeHNABmCXZ0MBcmsIDB
         sKvLNjQv2C/rc6fvHlTywW8yRPmDxnstzAjSg=
MIME-Version: 1.0
In-Reply-To: <20100110074529.GF7840@bicker>
References: <20100110074529.GF7840@bicker>
Date: Sun, 10 Jan 2010 10:38:37 +0000
Message-ID: <9b2b86521001100238x5c373f7x856a255e940baa5d@mail.gmail.com>
Subject: Re: [patch] hp-wmi: fix double free
From: Alan Jenkins <sourcejedi.lkml@googlemail.com>
To: Dan Carpenter <error27@gmail.com>, linux-kernel@vger.kernel.org
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1106
Lines: 31

On 1/10/10, Dan Carpenter <error27@gmail.com> wrote:
> kfree(obj) was called earlier.
>
> This was found by smatch and has only been compile tested.  :/

I don't see hp-wmi in MAINTAINERS, but in general platform drivers go
via the ACPI tree.

It looks like several others have discovered this issue the hard way
:-).  <http://www.pubbs.net/kernel/201001/14288/>.

Fortunately it has been fixed in the acpi tree and now submitted to
Linus.  <http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-01/msg02511.html>.

Regards
Alan

> --- orig/drivers/platform/x86/hp-wmi.c	2010-01-09 21:43:13.000000000 +0300
> +++ devel/drivers/platform/x86/hp-wmi.c	2010-01-09 21:43:28.000000000 +0300
> @@ -388,8 +388,6 @@ static void hp_wmi_notify(u32 value, voi
>  	} else
>  		printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n",
>  			eventcode);
> -
> -	kfree(obj);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/