Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511Ab0AJPMo (ORCPT ); Sun, 10 Jan 2010 10:12:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753093Ab0AJPMn (ORCPT ); Sun, 10 Jan 2010 10:12:43 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:56023 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068Ab0AJPMm (ORCPT ); Sun, 10 Jan 2010 10:12:42 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4B49EE5E.9040904@s5r6.in-berlin.de> Date: Sun, 10 Jan 2010 16:12:30 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.23) Gecko/20091025 SeaMonkey/1.1.18 MIME-Version: 1.0 To: linux-media@vger.kernel.org CC: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation References: In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 26 Stefan Richter wrote on 2009-12-26: > fdtv_fw_exit() is part of the firedtv driver's .exit.text section. ... > --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c > +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c > @@ -332,7 +332,7 @@ int __init fdtv_fw_init(void) > return driver_register(&fdtv_driver.driver); > } > > -void fdtv_fw_exit(void) > +void __exit fdtv_fw_exit(void) > { > driver_unregister(&fdtv_driver.driver); > fw_core_remove_address_handler(&fcp_handler); > This patch is bogus. fdtv_fw_exit() is also called from firedtv's init. -- Stefan Richter -=====-==-=- ---= -=-=- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/