Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166Ab0AKKQM (ORCPT ); Mon, 11 Jan 2010 05:16:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750977Ab0AKKQJ (ORCPT ); Mon, 11 Jan 2010 05:16:09 -0500 Received: from eddie.linux-mips.org ([78.24.191.182]:45347 "EHLO eddie.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752897Ab0AKKQH (ORCPT ); Mon, 11 Jan 2010 05:16:07 -0500 Date: Mon, 11 Jan 2010 11:15:43 +0100 From: Ralf Baechle To: KOSAKI Motohiro Cc: Hugh Dickins , linux-mips@linux-mips.org, Carsten Otte , Peter Zijlstra , KAMEZAWA Hiroyuki , Nick Piggin , Ingo Molnar , LKML , Thomas Gleixner , Darren Hart , Ulrich Drepper Subject: Re: [PATCH] mips,mm: Reinstate move_pte optimization Message-ID: <20100111101543.GD13886@linux-mips.org> References: <20091225083305.AA78.A69D9226@jp.fujitsu.com> <20100107151527.8784.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100107151527.8784.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 35 On Thu, Jan 07, 2010 at 03:32:57PM +0900, KOSAKI Motohiro wrote: > > to include/linux/mm.h - I'd prefer to keep it private if we can. > > But for completeness, this would involve resurrecting the 2.6.19 > > MIPS move_pte(), which makes sure mremap() move doesn't interfere > > with our assumptions. Something like > > > > #define __HAVE_ARCH_MOVE_PTE > > pte_t move_pte(pte_t pte, pgprot_t prot, unsigned long old_addr, > > unsigned long new_addr) > > { > > if (pte_present(pte) && is_zero_pfn(pte_pfn(pte))) > > pte = mk_pte(ZERO_PAGE(new_addr), prot); > > return pte; > > } > > > > in arch/mips/include/asm/pgtable.h. > > I agree with resurrecting mips move_pte. At least your patch > passed my cross compile test :) > > Ralf, can you please review following patch? Looks good. Acked-by: Ralf Baechle Thanks, Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/