From: Jeff Moyer <jmoyer@redhat.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: Shaohua Li <shaohua.li@intel.com>, Corrado Zoccolo <czoccolo@gmail.com>,
       Jens Axboe <jens.axboe@oracle.com>,
       Linux-Kernel <linux-kernel@vger.kernel.org>,
       Vivek Goyal <vgoyal@redhat.com>,
       Yanmin Zhang <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH] cfq-iosched: rework seeky detection
References: <1263052757-23436-1-git-send-email-czoccolo@gmail.com>
	<20100111014730.GA22362@sli10-desk.sh.intel.com>
	<4B4A92C7.10303@cn.fujitsu.com>
Date: Mon, 11 Jan 2010 09:20:18 -0500
In-Reply-To: <4B4A92C7.10303@cn.fujitsu.com> (Gui Jianfeng's message of "Mon,
	11 Jan 2010 10:53:59 +0800")
Message-ID: <x49my0ku3j1.fsf@segfault.boston.devel.redhat.com>
User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2003
Lines: 42

Gui Jianfeng <guijianfeng@cn.fujitsu.com> writes:

> Shaohua Li wrote:
>> On Sat, Jan 09, 2010 at 11:59:17PM +0800, Corrado Zoccolo wrote:
>>> Current seeky detection is based on average seek lenght.
>>> This is suboptimal, since the average will not distinguish between:
>>> * a process doing medium sized seeks
>>> * a process doing some sequential requests interleaved with larger seeks
>>> and even a medium seek can take lot of time, if the requested sector
>>> happens to be behind the disk head in the rotation (50% probability).
>>>
>>> Therefore, we change the seeky queue detection to work as follows:
>>> * each request can be classified as sequential if it is very close to
>>>   the current head position, i.e. it is likely in the disk cache (disks
>>>   usually read more data than requested, and put it in cache for
>>>   subsequent reads). Otherwise, the request is classified as seeky.
>>> * an history window of the last 32 requests is kept, storing the
>>>   classification result.
>>> * A queue is marked as seeky if more than 1/8 of the last 32 requests
>>>   were seeky.
>>>
>>> This patch fixes a regression reported by Yanmin, on mmap 64k random
>>> reads.
>> Can we not count a big request (say the request data is >= 32k) as seeky
>> regardless the seek distance? In this way we can also make a 64k random sync
>> read not as seeky.
>
>   Or maybe we can rely on *dynamic* CFQQ_SEEK_THR in terms of data lenght to 
>   determine whether a request should be a seeky one.

I'm not sure I understand the question, but it sounds like you're
assuming that the last_position tracks the beginning of the last I/O.
That's not the case.  It tracks the end of the last I/O, and so it
should not matter what the request size is.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/