Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532Ab0AKX7G (ORCPT ); Mon, 11 Jan 2010 18:59:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752255Ab0AKX7F (ORCPT ); Mon, 11 Jan 2010 18:59:05 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57669 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592Ab0AKX7D (ORCPT ); Mon, 11 Jan 2010 18:59:03 -0500 Date: Mon, 11 Jan 2010 15:59:12 -0800 (PST) Message-Id: <20100111.155912.68138954.davem@davemloft.net> To: mpm@selenic.com Cc: danborkmann@googlemail.com, linux-kernel@vger.kernel.org, jmoyer@redhat.com, netdev@vger.kernel.org, netdev@oss.sgi.com Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface From: David Miller In-Reply-To: <1263252108.29868.4774.camel@calx> References: <4B4630C0.6090206@gmail.com> <4B467A4D.9070708@gmail.com> <1263252108.29868.4774.camel@calx> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 17 From: Matt Mackall Date: Mon, 11 Jan 2010 17:21:48 -0600 > Looks pretty good. Dave? > > Acked-by: Matt Mackall I don't like the loop for RX ARP processing. The packet contents aren't going to change, so doing basic packet validation inside of the "for each RX client" loop of arp_reply() doesn't make any sense. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/