Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481Ab0ALAjv (ORCPT ); Mon, 11 Jan 2010 19:39:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754545Ab0ALAjn (ORCPT ); Mon, 11 Jan 2010 19:39:43 -0500 Received: from hera.kernel.org ([140.211.167.34]:48825 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754527Ab0ALAjl (ORCPT ); Mon, 11 Jan 2010 19:39:41 -0500 Message-ID: <4B4BC540.1090609@kernel.org> Date: Tue, 12 Jan 2010 09:41:36 +0900 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0 MIME-Version: 1.0 To: "Eric W. Biederman" CC: Greg Kroah-Hartman , Kay Sievers , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , Serge Hallyn , "Eric W. Biederman" Subject: Re: [PATCH 2/7] sysfs: Pack sysfs_dirent more tightly. References: <1263241315-19499-2-git-send-email-ebiederm@xmission.com> In-Reply-To: <1263241315-19499-2-git-send-email-ebiederm@xmission.com> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Tue, 12 Jan 2010 00:39:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 20 On 01/12/2010 05:21 AM, Eric W. Biederman wrote: > From: Eric W. Biederman > > Placing the 16bit s_mode between a pointer and a long doesn't pack well > especailly on 64bit where we wast 48 bits. So move s_mode and > declare it as a unsigned short. This is the sysfs backing store > after all we don't need fields extra large just in case someday > we want userspace to be able to use a larger value. > > Signed-off-by: Eric W. Biederman Acked-by: Tejun Heo -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/