Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527Ab0ALGsQ (ORCPT ); Tue, 12 Jan 2010 01:48:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751087Ab0ALGsQ (ORCPT ); Tue, 12 Jan 2010 01:48:16 -0500 Received: from mail-yx0-f187.google.com ([209.85.210.187]:39655 "EHLO mail-yx0-f187.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920Ab0ALGsP (ORCPT ); Tue, 12 Jan 2010 01:48:15 -0500 MIME-Version: 1.0 In-Reply-To: <1263275308.23507.18.camel@barrios-desktop> References: <1263271018.23507.8.camel@barrios-desktop> <1263275308.23507.18.camel@barrios-desktop> Date: Tue, 12 Jan 2010 12:18:14 +0530 Message-ID: Subject: Re: [PATCH] Fix reset of ramzswap From: Nitin Gupta To: Minchan Kim Cc: Greg KH , LKML , linux-mm Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 47 On Tue, Jan 12, 2010 at 11:18 AM, Minchan Kim wrote: > On Tue, 2010-01-12 at 11:00 +0530, Nitin Gupta wrote: >> On Tue, Jan 12, 2010 at 10:06 AM, minchan.kim wrote: >> >> Are you sure you checked this patch? > >> This check makes sure that you cannot reset an active swap device. >> When device in swapoff'ed the ioctl works as expected. >> > It seems my test was wrong. > Maybe my test case don't swapoff swap device. > Sorry. Ignore this patch, pz. > Thanks for the reivew, Nitin. > > I have one more patch. But I don't want to conflict your pending > patches. If it is right, pz, merge this patch with your pending series. > I will merge your patches with my pending series and add appropriate signed-off-by lines. > >From bf810ec09761b0f37eca7ba22d72fb2b1f2cba50 Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Tue, 12 Jan 2010 14:46:46 +0900 > Subject: [PATCH] Remove unnecessary check of ramzswap_write > > Nitin already implement swap slot free callback. > So, we don't need this test any more. > > Signed-off-by: Minchan Kim Great catch! thanks. I think, we should avoid adding linux-mm to CC list (unless its about xvmalloc allocator). LKML alone should be sufficient. Thanks, Nitin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/