Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288Ab0ALHCP (ORCPT ); Tue, 12 Jan 2010 02:02:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751475Ab0ALHCO (ORCPT ); Tue, 12 Jan 2010 02:02:14 -0500 Received: from rex.securecomputing.com ([203.24.151.4]:49457 "EHLO cyberguard.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751160Ab0ALHCN (ORCPT ); Tue, 12 Jan 2010 02:02:13 -0500 Message-ID: <4B4C1E82.7000907@snapgear.com> Date: Tue, 12 Jan 2010 17:02:26 +1000 From: Greg Ungerer User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Linus Torvalds CC: gerg@uclinux.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] m68knommu: change definitions of __pa() and __va() References: <201001120039.o0C0dboQ031390@goober.internal.moreton.com.au> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 51 Hi Linus, Linus Torvalds wrote: > On Tue, 12 Jan 2010, Greg Ungerer wrote: >> +#else >> +#define page_to_phys(page) ((page - mem_map) << PAGE_SHIFT) >> +#define page_to_bus(page) ((page - mem_map) << PAGE_SHIFT) >> +#endif > > Ok, so the old ones were total crap too, but when moving things around, > don't just copy the crap like this. > > Look at those two #define's for five seconds, and ask yourself what is > wrong with them. Those macros are not good. Ok. Easily fixed. page_to_bus() doesn't even look like it is used anywhere (and m68k itself doesn't define it). So I'll remove it. I propose changing page_to_phys() to be: #define page_to_phys(page) (page_to_pfn(page) << PAGE_SHIFT) Which seems consistent with many other arches. (And it works on m68knommu too :-) I'll generate a new patch with that changed. A quick grep shows page_to_phys() defined this way in a couple of other places too: h8300/include/asm/io.h sparc/include/asm/io_32.h Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/