Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753810Ab0ALI6f (ORCPT ); Tue, 12 Jan 2010 03:58:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753789Ab0ALI6e (ORCPT ); Tue, 12 Jan 2010 03:58:34 -0500 Received: from mga03.intel.com ([143.182.124.21]:23963 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753718Ab0ALI6d convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2010 03:58:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.47,316,1257148800"; d="scan'208";a="231740603" From: "Zheng, Shaohui" To: KAMEZAWA Hiroyuki CC: "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "ak@linux.intel.com" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" Date: Tue, 12 Jan 2010 16:57:40 +0800 Subject: RE: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel Thread-Topic: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel Thread-Index: AcqTXlxXPM1lKBXqSeyU7JJ+goXyyAAAT70g Message-ID: References: <20100112170433.394be31b.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100112170433.394be31b.kamezawa.hiroyu@jp.fujitsu.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 26 3 points... 1. I think this patch cannot be compiled in archs other than x86. Right ? IOW, please add static inline dummy... [Zheng, Shaohui] Agree, I will add a static dummy function 2. pgdat->[start,end], totalram_pages etc...are updated at memory hotplug. Please place the hook nearby them. [Zheng, Shaohui] Agree. 3. I recommend you yo use memory hotplug notifier. If it's allowed, it will be cleaner. It seems there are no strict ordering to update parameters this patch touches. [Zheng, Shaohui] Kame, do you means put the hook into function slab_mem_going_online_callback, it seems a good idea. If we select this method, we will need not to update these variable in function add_memory explicitly. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/