Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753424Ab0ALNTP (ORCPT ); Tue, 12 Jan 2010 08:19:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752943Ab0ALNTO (ORCPT ); Tue, 12 Jan 2010 08:19:14 -0500 Received: from mga02.intel.com ([134.134.136.20]:17373 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773Ab0ALNTO convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2010 08:19:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.49,262,1262592000"; d="scan'208";a="586443963" From: "Zheng, Shaohui" To: KAMEZAWA Hiroyuki CC: "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "ak@linux.intel.com" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" Date: Tue, 12 Jan 2010 21:17:40 +0800 Subject: RE: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel Thread-Topic: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel Thread-Index: AcqTZbuTmdV7v9ZzQia6d7Cb3MStJgAIpV5w Message-ID: References: <20100112170433.394be31b.kamezawa.hiroyu@jp.fujitsu.com> <20100112175724.adfa04d6.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100112175724.adfa04d6.kamezawa.hiroyu@jp.fujitsu.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1417 Lines: 31 > > 3 points... > 1. I think this patch cannot be compiled in archs other than x86. Right ? > IOW, please add static inline dummy... > [Zheng, Shaohui] Agree, I will add a static dummy function > > 2. pgdat->[start,end], totalram_pages etc...are updated at memory hotplug. > Please place the hook nearby them. > [Zheng, Shaohui] Agree. > > 3. I recommend you yo use memory hotplug notifier. > If it's allowed, it will be cleaner. > It seems there are no strict ordering to update parameters this patch touches. > > [Zheng, Shaohui] Kame, do you means put the hook into function slab_mem_going_online_callback, it seems a good idea. If we select this method, we will need not to update these variable in function add_memory explicitly. > yes. I think callback is the best. [Zheng, Shaohui] Kame, I check the code carefully and write a simple patch, I found the callback will never be executed. The only entrance of this callback is in function online_pages/offline_pages, but I did not found explicit call to these 2 functions. Do we need to add a memory_notify to trigger this callback in function add_memory? Thanks, -Kame Thanks & Regards, Shaohui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/