Message-ID: <4B4CAA15.4030200@freemail.hu>
Date: Tue, 12 Jan 2010 17:57:57 +0100
From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= <nm127@freemail.hu>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16
MIME-Version: 1.0
To: David Vrabel <david.vrabel@csr.com>
CC: linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
       Julia Lawall <julia@diku.dk>, cocci@diku.dk
Subject: Re: [PATCH] uwb: make USB device id constant
References: <4B4C297A.5090405@freemail.hu> <4B4C9ED9.60905@csr.com>
In-Reply-To: <4B4C9ED9.60905@csr.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-DCC-mail.t-online.hu-Metrics: mail02a.mail.t-online.hu 32721; Body=5 Fuz1=5
	Fuz2=5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1018
Lines: 29

David Vrabel írta:
> Németh Márton wrote:
>> From: Márton Németh <nm127@freemail.hu>
>>
>> The id_table field of the struct usb_device_id is constant in <linux/usb.h>
>> so it is worth to make the initialization data also constant.
> 
> Thanks.
> 
>> The semantic match that finds this kind of pattern is as follows:
>> (http://coccinelle.lip6.fr/)
> 
> Can you please not include this as part of the changelog in future?  You
> may include it after the '---' if you wish.

It is common for patches generated by spatch that they include the SmPL
which was used to generate the patch.
See http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git&a=search&h=HEAD&st=commit&s=%3Csmpl%3E

But you can leave it out, if you wish.

Regards,

	Márton Németh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/