Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754206Ab0ALR1u (ORCPT ); Tue, 12 Jan 2010 12:27:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753939Ab0ALR1t (ORCPT ); Tue, 12 Jan 2010 12:27:49 -0500 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:53449 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753649Ab0ALR1s (ORCPT ); Tue, 12 Jan 2010 12:27:48 -0500 X-Sasl-enc: UqPjqfPxQEc6jPOlqRXn1pLpcvKVDwCk4yfU2JO0190a 1263314537 Message-ID: <4B4CA666.1050505@imap.cc> Date: Tue, 12 Jan 2010 17:42:14 +0100 From: Tilman Schmidt User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.1.7) Gecko/20100104 SeaMonkey/2.0.2 MIME-Version: 1.0 To: Greg KH CC: Stephen Rothwell , LKML , netdev@vger.kernel.org, Karsten Keil , isdn4linux@listserv.isdn4linux.de Subject: Re: Can we remove pci_find_device() yet? References: <20100108112236.462a3da2.sfr@canb.auug.org.au> <20100108044646.GC6611@suse.de> <4B4B802A.2010709@imap.cc> <20100111200136.GA29955@suse.de> In-Reply-To: <20100111200136.GA29955@suse.de> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 46 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2010-01-11 21:01 schrieb Greg KH: > On Mon, Jan 11, 2010 at 08:46:50PM +0100, Tilman Schmidt wrote: >> >> Just an idea - as a stopgap measure, couldn't pci_find_device() be made >> a private function of the HiSax drivers? That way, the remainder of the >> kernel won't be polluted by it anymore, and the PCI_LEGACY config option >> can be dropped. Something like this quick and dirty hack: > > Close, but if you do this, please name the function > hisax_find_pci_device() or something, and change the drivers to use it Sorry, but no. That would drag me into the checkpatch.pl swamp, a place I know well enough by now to avoid it whenever possible. Many of the calls to pci_find_device() have checkpatch problems which of course do not go away by just substituting another function name, so I would be obliged to restructure all those call sites by hand for the sake of "not introducing new code with checkpatch problems". BTDT. So I'll drop that idea. If someone else wants to pick it up, feel free to do so. Regards, Tilman - -- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge?ffnet mindestens haltbar bis: (siehe R?ckseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAktMpmYACgkQQ3+did9BuFuJKgCggRImZ3NOTmCJUpUktreervtz fegAniAexJirz3p/AXPB6EpsCEJn3hPL =QwUB -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/