Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754703Ab0ALSNk (ORCPT ); Tue, 12 Jan 2010 13:13:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754591Ab0ALSNj (ORCPT ); Tue, 12 Jan 2010 13:13:39 -0500 Received: from smtp.nokia.com ([192.100.122.233]:43333 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754543Ab0ALSNh (ORCPT ); Tue, 12 Jan 2010 13:13:37 -0500 From: Tiago Vignatti To: Dave Airlie Cc: Jesse Barnes , Benjamin Herrenschmidt , "Paulo R. Zanoni" , Henry Zhao , Andy Getzendanner , Brad Spengler , "dri-devel@lists.sf.net" , "linux-kernel@vger.kernel.org" , Tiago Vignatti Subject: [PATCH] vgaarb: fix trylock behaviour accordingly vga_tryget return value Date: Tue, 12 Jan 2010 19:58:32 +0200 Message-Id: <1263319113-6631-2-git-send-email-tiago.vignatti@nokia.com> X-Mailer: git-send-email 1.6.0.4 In-Reply-To: <1263319113-6631-1-git-send-email-tiago.vignatti@nokia.com> References: <1263319113-6631-1-git-send-email-tiago.vignatti@nokia.com> X-OriginalArrivalTime: 12 Jan 2010 18:12:54.0181 (UTC) FILETIME=[DC3B3550:01CA93B2] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 30 From: Henry Zhao Signed-off-by: Tiago Vignatti --- Henry, can you Signed-off-by there? drivers/gpu/vga/vgaarb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c index 2f6cf69..0f5f64d 100644 --- a/drivers/gpu/vga/vgaarb.c +++ b/drivers/gpu/vga/vgaarb.c @@ -935,7 +935,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user * buf, goto done; } - if (vga_tryget(pdev, io_state)) { + if (!vga_tryget(pdev, io_state)) { /* Update the client's locks lists... */ for (i = 0; i < MAX_USER_CARDS; i++) { if (priv->cards[i].pdev == pdev) { -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/