Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550Ab0AMEkS (ORCPT ); Tue, 12 Jan 2010 23:40:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753320Ab0AMEkQ (ORCPT ); Tue, 12 Jan 2010 23:40:16 -0500 Received: from mail-iw0-f197.google.com ([209.85.223.197]:52372 "EHLO mail-iw0-f197.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752970Ab0AMEkP (ORCPT ); Tue, 12 Jan 2010 23:40:15 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=I07Twy3HgDKywdnwgthhMUZRAzxLKSft9WcygsabOcIpTU00rCqGWfCVm779Cu9Y+2 fW8sFPYG5xFqeiiGFhXe6uSEGveGIkzXhVQBd+xT+fZ1fHyneiWdjQTkIW+3Yicx4/LF gAvLCI3ckLXCyKBeXYaIfIRe48vPxVz5V5C1M= Message-ID: <4B4D4EAA.2010109@gmail.com> Date: Tue, 12 Jan 2010 22:40:10 -0600 From: Robert Hancock User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: Seth Heasley CC: jgarzik@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.32.3] ahci: AHCI and RAID mode SATA patch for Intel Cougar Point DeviceIDs References: <201001121700.18234.seth.heasley@intel.com> In-Reply-To: <201001121700.18234.seth.heasley@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2032 Lines: 40 On 01/12/2010 07:00 PM, Seth Heasley wrote: > This patch adds the Intel Cougar Point (PCH) SATA AHCI and RAID Controller DeviceIDs. > > Signed-off-by: Seth Heasley > > --- linux-2.6.32.3/drivers/ata/ahci.c.orig 2010-01-06 15:07:45.000000000 -0800 > +++ linux-2.6.32.3/drivers/ata/ahci.c 2010-01-07 13:55:23.000000000 -0800 > @@ -560,6 +560,12 @@ > { PCI_VDEVICE(INTEL, 0x3b2b), board_ahci }, /* PCH RAID */ > { PCI_VDEVICE(INTEL, 0x3b2c), board_ahci }, /* PCH RAID */ > { PCI_VDEVICE(INTEL, 0x3b2f), board_ahci }, /* PCH AHCI */ > + { PCI_VDEVICE(INTEL, 0x1c02), board_ahci }, /* CPT AHCI */ > + { PCI_VDEVICE(INTEL, 0x1c03), board_ahci }, /* CPT AHCI */ > + { PCI_VDEVICE(INTEL, 0x1c04), board_ahci }, /* CPT RAID */ > + { PCI_VDEVICE(INTEL, 0x1c05), board_ahci }, /* CPT RAID */ > + { PCI_VDEVICE(INTEL, 0x1c06), board_ahci }, /* CPT RAID */ > + { PCI_VDEVICE(INTEL, 0x1c07), board_ahci }, /* CPT RAID */ > > /* JMicron 360/1/3/5/6, match class to avoid IDE function */ > { PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, The RAID mode entries would be needed if the device indicates RAID class in that mode, but in plain AHCI mode it should indicate SATA AHCI class which will get picked up by this catch-all so those entries shouldn't be needed: /* Generic, PCI class code for AHCI */ { PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci }, Likely a lot of the existing specific PCI IDs could be removed from the driver because of this (many likely predate the addition of the class-based catch-all). The only reason to need a specific entry if the device uses AHCI class is if it needs special handling or workarounds, which isn't the case here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/