DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=fvsrzpj5AU4TVtyiNV0kthIxQo3ketPafnyFwHZOX2jF5ok+OCEuX2mXIC7lOWvE+s
         Us/CyQ0XrbSobEYfEnR7JLyD8Qu7k+GhGYgZhpOmKPrDHW4BTAM+W1Fhui0xtRhSXzbN
         BYTqyHjzad7UTCHj+3L+jyZoCbTXoH6hL8k7g=
MIME-Version: 1.0
In-Reply-To: <20100112080600.392c14cd@infradead.org>
References: <ce2c83091001120309q19d58b45kc27610fc31ce01dc@mail.gmail.com>
	 <20100112080600.392c14cd@infradead.org>
Date: Wed, 13 Jan 2010 13:25:20 +0800
Message-ID: <ce2c83091001122125i6aac119fk470621fb6b1c2b4c@mail.gmail.com>
Subject: Re: Did we really need to clear the IF flag at prepare_singlestep() 
	of x86 kprobes?
From: Dongdong Deng <libfetion@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, ananth@in.ibm.com,
       anil.s.keshavamurthy@intel.com, davem@davemloft.net,
       mhiramat@redhat.com, jkenisto@us.ibm.com
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1485
Lines: 55

On Wed, Jan 13, 2010 at 12:06 AM, Arjan van de Ven <arjan@infradead.org> wrote:
> On Tue, 12 Jan 2010 19:09:35 +0800
> Dongdong Deng <libfetion@gmail.com> wrote:
>
>> Hi Kprobe experts,
>>
>> I have a doubt about the handling "X86_EFLAGS_IF" at
>> prepare_singlestep(), Could you give me some suggestions?
>
>
> iirc it was a security thing; we used to have some exploits
> due to the linux-abi entry points which caused a mess, and this
> was put there as defensive programming.

Hi Arjan,

Thanks for your explain. :)

Do you means that the user will modify the IF? for example: through
"p->pre_handler(p, regs)" .

But I couldn't image the affect that if user modify the IF flag, could
you give me a detail info about security thing?


BTW:

Before linux 2.5, the debug tarp was initalized as trap gate:

linux-2.4.37/arch/i386/kernel/traps.c:966:	set_trap_gate(1,&debug);

I know kprobes have a long history,  Is it possible that the interrupt
flag of kprobes was introduced at that time?


Thanks,
Dongdong


>
> I could totally misremember this as well of course.
>
>
> --
> Arjan van de Ven        Intel Open Source Technology Centre
> For development, discussion and tips for power savings,
> visit http://www.lesswatts.org
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/