Date: Wed, 13 Jan 2010 06:13:41 -0500
From: Vivek Goyal <vgoyal@redhat.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Corrado Zoccolo <czoccolo@gmail.com>,
       "jens.axboe@oracle.com" <jens.axboe@oracle.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "jmoyer@redhat.com" <jmoyer@redhat.com>,
       "guijianfeng@cn.fujitsu.com" <guijianfeng@cn.fujitsu.com>,
       "yanmin_zhang@linux.intel.com" <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH]cfq-iosched: don't stop async queue with async requests
	pending
Message-ID: <20100113111341.GB3087@redhat.com>
References: <20100113074442.GA10492@sli10-desk.sh.intel.com> <4e5e476b1001130018n2ad9e830s4a20d922abd4c7bb@mail.gmail.com> <20100113082322.GA24345@sli10-desk.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100113082322.GA24345@sli10-desk.sh.intel.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1506
Lines: 28

On Wed, Jan 13, 2010 at 04:23:22PM +0800, Shaohua Li wrote:
> On Wed, Jan 13, 2010 at 04:18:47PM +0800, Corrado Zoccolo wrote:
> > On Wed, Jan 13, 2010 at 8:44 AM, Shaohua Li <shaohua.li@intel.com> wrote:
> > > My SSD speed of direct write is about 80m/s, while I test page writeback,
> > > the speed can only go to 68m/s. Below patch fixes this.
> > > It appears we missused cfq_should_idle in cfq_may_dispatch. cfq_should_idle
> > > means a queue should idle because it's seekless sync queue or it's the last queue,
> > > which is to maintain service tree time slice. So it doesn't mean the
> > > last queue is always a sync queue. If the last queue is asyn queue,
> > > we definitely shouldn't stop dispatch requests because of pending async
> > > requests.
> > 
> > An other option is that cfq_should_idle returns false for async
> > queues, since cfq will never idle on them.
> I'm considering this option too, but it appears we need make async queue
> idle to maintain domain time slice.

IMHO, we don't have to wait on async write service tree. Generally aysnc
write queus contain many requests and they are not like reads where next
request is expected. So idling on aysnc write service tree is waste of
time and will lead to reduced throughput.

Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/