Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900Ab0AMNVn (ORCPT ); Wed, 13 Jan 2010 08:21:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754299Ab0AMNVm (ORCPT ); Wed, 13 Jan 2010 08:21:42 -0500 Received: from smtp1.entryit.no ([212.4.42.179]:50170 "EHLO smtp1.entryit.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753849Ab0AMNVl convert rfc822-to-8bit (ORCPT ); Wed, 13 Jan 2010 08:21:41 -0500 From: Eirik Aanonsen To: Eirik Aanonsen , "kernel@avr32linux.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 13 Jan 2010 14:20:40 +0100 Subject: RE: [PATCH 1/1] atmel uaba : Adding invert vbus_pin Thread-Topic: [PATCH 1/1] atmel uaba : Adding invert vbus_pin Thread-Index: AcqN48dOrjX+1T2DTKONu97r3uR6wQGbqWNg Message-ID: References: In-Reply-To: Accept-Language: nb-NO Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: nb-NO Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 41 > Subject: [PATCH 1/1] atmel uaba : Adding invert vbus_pin > > Thanks to Ben Nizette [bn@niasdigital.com] and Sergei Shtylyov > [sshtylyov@ru.mvista.com] for good feedback > > Adding vbus_pin_inverted so that the usb detect pin can be active high > or low. > This because depending on HW implementation it is better to have active > low. > Also replaced the pio_get_value(udc->vbus_pin); with a call to > vbus_is_present(udc); > > Signed-off-by: Eirik Aanonsen > --- ... No one that have any comments on this? Haavard is it possible to get this upstream? The patch allows the USB driver to be active and when the USB bus is disconnected (with reversed signaling). I observe a drop in power consumption of 150mW, and for people dependent on battery that is a lot. And in our design we need to have this pin inverted. Regards ____________________________________________________ Eirik Aanonsen SW Developer E-mail: eaa@wprmedical.com Phone: +47 90 68 11 92 Fax: +47 37 03 56 77 ____________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/