DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=MQ4fEvl2sWI94GZ7+C6dA5br3fUjjeTuY8kBZRj0eEwIbqeTMGp/obee16u3U6t62z
         z2kPUAOpRG5GDiT4Gfuw17Q6SWkuSRmloRyMw+SZkmNv078pRxbtA2TWQ5F4zFTKg+CM
         JtQzQCndHTCl4dKFLH+mq1ReRbzH7tm3mZK0A=
Date: Wed, 13 Jan 2010 15:28:01 +0100
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>,
       Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/3] rbtree: Introduce rb_for_each_entry
Message-ID: <20100113142800.GC5036@nowhere>
References: <1263387673-15231-1-git-send-email-acme@infradead.org> <1263388569.4244.215.camel@laptop> <20100113133442.GB5036@nowhere> <20100113135205.GC5576@ghostprotocols.net> <1263391133.4244.226.camel@laptop> <20100113141344.GG2934@ghostprotocols.net> <1263392296.4244.228.camel@laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1263392296.4244.228.camel@laptop>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2164
Lines: 50

On Wed, Jan 13, 2010 at 03:18:16PM +0100, Peter Zijlstra wrote:
> On Wed, 2010-01-13 at 12:13 -0200, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jan 13, 2010 at 02:58:53PM +0100, Peter Zijlstra escreveu:
> > > On Wed, 2010-01-13 at 11:52 -0200, Arnaldo Carvalho de Melo wrote:
> > > > Em Wed, Jan 13, 2010 at 02:34:45PM +0100, Frederic Weisbecker escreveu:
> > > > > At least it matches many patterns in perf :)
> > > > 
> > > > What an insane piece of... software! 8-) Whatever, if it makes Peter
> > > > happy we can keep it on tools/perf/util/include/linux/rbtree.h, just
> > > > after the:
> > > > 
> > > > #include "../../../../include/linux/rbtree.h"
> > > > 
> > > > ;-)
> > > > 
> > > > Just like we have list_del_range() in tools/perf/util/include/linux/list.h.
> > > 
> > > That's not the point, doing a for_each on the rb-trees as we have today
> > > is a O(n log(n)) operation, not something you should want to do often.
> > > 
> > > Adding a helper promotes the idea that its a sane thing to do, its not.
> > > 
> > > If you really need it, open coding it isn't hard, but the lack of helper
> > > does make you think and hopefully realize you're doing something funny.
> > 
> > We need it in several places in the perf tools, to present sorted results, to
> > dump the maps for debugging purposes, etc.
> > 
> > But I'll go and look at each one of them to see if there is any where it
> > is used in some stupid way.
> 
> Sure, but again, that's missing the point, adding that helper isn't a
> good thing. We have no 64bit division operators in Linux either, for the
> very same reason.
> 


I don't understand why this is unsane. Sure it is O(n log(n)), but
that's what is suitable for our use in perf. Shouldn't we simplify
it through a helper just because it's not something sane in most
other cases?

But yeah, such helper inside the kernel wouldn't be sane, as it
wouldn't fit any sane need I guess.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/