Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149Ab0AMRIr (ORCPT ); Wed, 13 Jan 2010 12:08:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756106Ab0AMRIq (ORCPT ); Wed, 13 Jan 2010 12:08:46 -0500 Received: from mail-yx0-f187.google.com ([209.85.210.187]:59356 "EHLO mail-yx0-f187.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756078Ab0AMRIp (ORCPT ); Wed, 13 Jan 2010 12:08:45 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=mRwlVOs5KqENWbND2S7DE8AGHMf3fhdgGizvFfUWcssIiRLBn0NQLUm9tJCyJBI8X+ CBV/xrUTlz2ezhumUW6qW0n7ozQ9drrUc/0PImzLHRJjJqkpDpH0gPJ1p+OniMpkDIuv DitwUP2ARVmqxog22DMZbegZYMbBHnb+/OGUE= Message-ID: <4B4DFE1A.4000606@pobox.com> Date: Wed, 13 Jan 2010 12:08:42 -0500 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Krzysztof Halasa CC: Robert Hancock , Seth Heasley , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.32.3] ahci: AHCI and RAID mode SATA patch for Intel Cougar Point DeviceIDs References: <201001121700.18234.seth.heasley@intel.com> <4B4D4EAA.2010109@gmail.com> <4B4DAA68.60608@pobox.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2022 Lines: 56 On 01/13/2010 10:15 AM, Krzysztof Halasa wrote: > Jeff Garzik writes: > >> Well, two lines of thinking here: >> >> * some of lines of Intel chips do not separate AHCI into a separate >> PCI ID rather legacy IDE interface. When an AHCI interface exists and >> AHCI/IDE share the same PCI ID, we default to using AHCI. Thus, some >> of those PCI ID matches in ahci.c's PCI table may not get caught by >> the generic PCI class match at the end of the table. >> >> * the cost carrying redundant PCI IDs seems low, harmless, and >> potentially helpful. > > Also people may use things like this: > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index a3241a1..0616bbb 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -561,9 +561,11 @@ static const struct pci_device_id ahci_pci_tbl[] = { > { PCI_VDEVICE(INTEL, 0x3b2c), board_ahci }, /* PCH RAID */ > { PCI_VDEVICE(INTEL, 0x3b2f), board_ahci }, /* PCH AHCI */ > > +#ifdef DOESNT_WORK_FOR_ME > /* JMicron 360/1/3/5/6, match class to avoid IDE function */ > { PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, > PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci_ign_iferr }, > +#endif > > /* ATI */ > { PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 */ > @@ -667,9 +669,11 @@ static const struct pci_device_id ahci_pci_tbl[] = { > /* Promise */ > { PCI_VDEVICE(PROMISE, 0x3f20), board_ahci }, /* PDC42819 */ > > +#ifdef DOESNT_WORK_FOR_ME > /* Generic, PCI class code for AHCI */ > { PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, > PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci }, > +#endif > I'm not sure I understand your point. Are there ahci problems with the generic entries, that remain unresolved? Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/