Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372Ab0AMTpG (ORCPT ); Wed, 13 Jan 2010 14:45:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753763Ab0AMTpE (ORCPT ); Wed, 13 Jan 2010 14:45:04 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:41999 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753602Ab0AMTpB (ORCPT ); Wed, 13 Jan 2010 14:45:01 -0500 Date: Wed, 13 Jan 2010 19:44:58 +0000 From: Al Viro To: OGAWA Hirofumi Cc: Tyler Hicks , Dustin Kirkland , ecryptfs-devel@lists.launchpad.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] ecryptfs: Fix refcnt leak on ecryptfs_follow_link() error path Message-ID: <20100113194458.GB4673@ZenIV.linux.org.uk> References: <87my0kjxpd.fsf@devron.myhome.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87my0kjxpd.fsf@devron.myhome.or.jp> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 563 Lines: 14 On Tue, Jan 12, 2010 at 03:36:14AM +0900, OGAWA Hirofumi wrote: > > If ->follow_link handler return the error, it should decrement > nd->path refcnt. But, ecryptfs_follow_link() doesn't decrement. > > This patch fix it by using usual nd_set_link() style error handling, > instead of playing with nd->path. Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/