Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755625Ab0AMUHP (ORCPT ); Wed, 13 Jan 2010 15:07:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755087Ab0AMUHN (ORCPT ); Wed, 13 Jan 2010 15:07:13 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:52470 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754618Ab0AMUHM (ORCPT ); Wed, 13 Jan 2010 15:07:12 -0500 Date: Wed, 13 Jan 2010 20:07:11 +0000 From: Al Viro To: OGAWA Hirofumi Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/2] vfs: Fix refcnt leak with __do_follow_link() in do_filp_open() Message-ID: <20100113200711.GD19799@ZenIV.linux.org.uk> References: <87vdf8jxug.fsf@devron.myhome.or.jp> <87r5pwjxr2.fsf@devron.myhome.or.jp> <20100113195059.GC4673@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100113195059.GC4673@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 18 On Wed, Jan 13, 2010 at 07:51:00PM +0000, Al Viro wrote: > Point, but... that's not the way I'd do it (again, see #untested for the > direction it's heading). What we ought to do is simply "put ourselves > in trust-no-one mode (LOOKUP_REVAL) and restart the entire thing; if > we'd already been through that, fail immediately". > > And yes, it needs to be pulled in front of queue and go in before .34. > Will do shortly. See commit 1fe1244faf0e862342bd2ae29e341cc957469aee in vfs-2.6.git#for-linus (that's going to be rc5 fixes push tonight, after several more things get shifted there). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/