Date: Wed, 13 Jan 2010 15:17:55 -0800
From: Greg KH <gregkh@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
       linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Paul Mackerras <paulus@samba.org>,
       Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 5/5] lockdep: Fix the way to initialize class_mutex for
 information of file and line
Message-ID: <20100113231755.GA12325@suse.de>
References: <4B45B9C1.2040900@dcl.info.waseda.ac.jp>
 <1262860795-5745-6-git-send-email-mitake@dcl.info.waseda.ac.jp>
 <20100113100022.GA11386@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100113100022.GA11386@elte.hu>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1824
Lines: 46

On Wed, Jan 13, 2010 at 11:00:22AM +0100, Ingo Molnar wrote:
> 
> * Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
> 
> > This patch adds __FILE__ and __LINE__ to arguments passed for
> > __mutex_init() called in __class_register().
> > This affects to lockdep_map of class_mutex of struct class_private,
> > and these will be used to make trace lock events more human friendly.
> > 
> > Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > ---
> >  drivers/base/class.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/base/class.c b/drivers/base/class.c
> > index 161746d..cc0630f 100644
> > --- a/drivers/base/class.c
> > +++ b/drivers/base/class.c
> > @@ -162,7 +162,8 @@ int __class_register(struct class *cls, struct lock_class_key *key)
> >  	klist_init(&cp->class_devices, klist_class_dev_get, klist_class_dev_put);
> >  	INIT_LIST_HEAD(&cp->class_interfaces);
> >  	kset_init(&cp->class_dirs);
> > -	__mutex_init(&cp->class_mutex, "struct class mutex", key);
> > +	__mutex_init(&cp->class_mutex, "struct class mutex", key,
> > +		     __FILE__, __LINE__);
> >  	error = kobject_set_name(&cp->class_subsys.kobj, "%s", cls->name);
> >  	if (error) {
> >  		kfree(cp);
> 
> Greg, any objection to this type of embellishment of lock data that comes from 
> the driver core?

No, I'll queue it up in my tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/