Date: Wed, 13 Jan 2010 18:42:44 -0500
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Nicholas Miell <nmiell@comcast.net>
Cc: David Daney <ddaney@caviumnetworks.com>, paulmck@linux.vnet.ibm.com,
       linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
       Oleg Nesterov <oleg@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
       Ingo Molnar <mingo@elte.hu>, akpm@linux-foundation.org,
       josh@joshtriplett.org, tglx@linutronix.de, Valdis.Kletnieks@vt.edu,
       dhowells@redhat.com, laijs@cn.fujitsu.com, dipankar@in.ibm.com
Subject: Re: [RFC PATCH] introduce sys_membarrier(): process-wide memory
	barrier (v5)
Message-ID: <20100113234244.GA15897@Krystal>
References: <1263358823.3874.10.camel@entropy> <20100113053126.GC6781@linux.vnet.ibm.com> <1263361196.3874.12.camel@entropy> <20100113143805.GC30875@Krystal> <1263406071.3874.16.camel@entropy> <20100113182442.GA20704@Krystal> <1263408098.3874.19.camel@entropy> <20100113191727.GA24742@Krystal> <4B4E2208.4030307@caviumnetworks.com> <1263412407.3874.21.camel@entropy>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <1263412407.3874.21.camel@entropy>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2525
Lines: 67

* Nicholas Miell (nmiell@comcast.net) wrote:
> On Wed, 2010-01-13 at 11:42 -0800, David Daney wrote:
> > Mathieu Desnoyers wrote:
> > > * Nicholas Miell (nmiell@comcast.net) wrote:
> > >> On Wed, 2010-01-13 at 13:24 -0500, Mathieu Desnoyers wrote:
> > >>> * Nicholas Miell (nmiell@comcast.net) wrote:
> > >>>
> > >>>> The whole point of compat and incompat flags is that it allows new
> > >>>> applications to run on old kernels and either work or fail as
> > >>>> appropriate, depending on whether the new features they're using must be
> > >>>> implemented or can be silently ignored.
> > >>> I see. Thanks for the explanation. Then the expedited flag should
> > >>> clearly be part of the mandatory flags.
> > >>>
> > >>> Can you point me to other system calls that are doing this ?
> > >>>
> > >>> Thanks,
> > >>>
> > >>> Mathieu
> > >> Not off the top of my head, but I did steal the idea from the ext2/3/4
> > >> disk format.
> > > 
> > > Sounds a bit over-engineered to me for system calls, but who knows if we
> > > eventually have to extend sys_membarrier(). This involves that, right
> > > now, I'd have to add a header to include/linux to define these flags.
> > > Also, "int expedited" is a bit clearer, but less flexible, than "int
> > > flags". Anyone else have comments about this ?
> > > 
> > 
> > It doesn't bother me that you have to do extra work to add the flag 
> > definitions to a header file. :-)
> > 

Work is not a problem. I just wanted to make sure I would not be going
in circles. :)

> > As I understand it, the proposal is to have the option to extend the ABI 
> > based on as yet undefined flag bits.  This doesn't seem like a bad thing.
> > 
> > The runtime overhead of testing a single bit vs. non-zero in the 
> > parameter shouldn't be an issue.
> > 
> 
> The recent introduction of accept4(), signalfd4(), eventfd2(),
> epoll_create1(), dup3(), pipe2(), and inotify_init1() suggest that this
> is the kind of thing you want to plan for, because you're probably going
> to end up doing it anyway.

Yes, that's a very convincing argument. OK, I'll cook something for v6.

Thanks a lot,

Mathieu

> 
> -- 
> Nicholas Miell <nmiell@comcast.net>
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/